Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Preview button is disable when create a rule by adding only a filter without adding any query #139226

Merged
merged 1 commit into from
Aug 23, 2022
Merged

[Security Solution] Preview button is disable when create a rule by adding only a filter without adding any query #139226

merged 1 commit into from
Aug 23, 2022

Conversation

e40pud
Copy link
Contributor

@e40pud e40pud commented Aug 22, 2022 •
edited by kibanamachine
Loading

Summary

These changes allows user to preview rules when query is not set though filters are selected.

Fixes #139179

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@e40pud e40pud added release_note:fix Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Team:Detection Alerts Security Detection Alerts Area Team backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:cloud-deploy Create or update a Cloud deployment labels Aug 22, 2022
@e40pud e40pud self-assigned this Aug 22, 2022
@e40pud e40pud requested a review from a team as a code owner August 22, 2022 16:54
@e40pud e40pud requested a review from jpdjere August 22, 2022 16:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 5.4MB 5.4MB +40.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @e40pud

jpdjere
jpdjere approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@jpdjere jpdjere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, works as described, LGTM 👍

@e40pud e40pud merged commit 0212338 into elastic:main Aug 23, 2022
@kibanamachine kibanamachine mentioned this pull request Aug 23, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 23, 2022
@e40pud
[Security Solution] Preview button is disable when create a rule by a…
949a2e7 
…dding only a filter without adding any query (elastic#139179) (elastic#139226)

(cherry picked from commit 0212338)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Aug 23, 2022
@kibanamachine @e40pud
[Security Solution] Preview button is disable when create a rule by a…
7ffc375 
…dding only a filter without adding any query (#139179) (#139226) (#139275)

(cherry picked from commit 0212338)

Co-authored-by: Ievgen Sorokopud <[email protected]>
Mpdreamz pushed a commit to Mpdreamz/kibana that referenced this pull request Sep 6, 2022
@e40pud @Mpdreamz
[Security Solution] Preview button is disable when create a rule by a…
0ea0dce 
…dding only a filter without adding any query (elastic#139179) (elastic#139226)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpdjere jpdjere jpdjere approved these changes

Assignees

@e40pud e40pud

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:cloud-deploy Create or update a Cloud deployment release_note:fix Team:Detection Alerts Security Detection Alerts Area Team Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.4.0 v8.5.0
Projects
None yet
Milestone
No milestone
5 participants
@e40pud @elasticmachine @kibana-ci @kibanamachine @jpdjere